Remove StarknetChainId #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change name to `StarknetChainId.name` for chain id `SN_NAME`
THenry14
approved these changes
Feb 6, 2024
DelevoXDG
added a commit
that referenced
this pull request
Feb 16, 2024
This reverts commit 34c7260.
DelevoXDG
added a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Can be unblocked after #137 is mergedStarknetChainIdenum, useFeltinsteadLinked issues
Closes #138
Breaking changes
StarknetChainIdenumStarknetProviderProtocol.getChainIdnow returnsFeltinstead ofStarknetChainId; useFelt.toShortStringto convert to readable nameStarknetTransactionHashCalculatormethods now take chain id asFeltinstead ofStarknetChainId