Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StarknetMerkleTree and merkletree support in StarknetTypedData #167

Merged
merged 69 commits into from
Apr 8, 2024
Merged

Add StarknetMerkleTree and merkletree support in StarknetTypedData #167

merged 69 commits into from
Apr 8, 2024

Commits on Mar 18, 2024

  1. Update StarknetExecutionResources; Add StarknetComputationResources 

    - Add `dataAvailability` to `StarknetExecutionResources`; Add `StarknetDataAvailability
  - Add `executionResources` to tx traces
- Add `StarknetComputationResources`
  - Add `computationResources` to `StarknetFunctionInvocation`
- Add `StarknetResources` protocol with common fields
    @DelevoXDG
    DelevoXDG committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    cd299f8 View commit details
    Browse the repository at this point in the history

  2. Update prefund amounts and max fee for declare in DevnetClient 

    - Prefund account with `5_000_000_000_000_000`->`5_000_000_000_000_000_000`
- Change max fee in declare methods to `1_000_000_000_000_000`->`10_000_000_000_000_000`
    @DelevoXDG
    DelevoXDG committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d2d94df View commit details
    Browse the repository at this point in the history

  3. Adjust tx receipt tests

    @DelevoXDG
    DelevoXDG committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e012d54 View commit details
    Browse the repository at this point in the history

  4. Update StarknetFeeEstimate and related logic 

    - Add `dataGasConsumed`, `dataGasPrice` fields to `StarknetFeeEstimate`
- Update `.toResourceBounds()` extension
  - Update overheads
  - Use new logic
    @DelevoXDG
    DelevoXDG committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    96fc841 View commit details
    Browse the repository at this point in the history

  5. Finish "Update prefund amounts and max fee for declare in DevnetClient"

    @DelevoXDG
    DelevoXDG committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    24de548 View commit details
    Browse the repository at this point in the history

  6. Fix docstring for toResourceBounds

    @DelevoXDG
    DelevoXDG committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2a36b16 View commit details
    Browse the repository at this point in the history

  7. Use ternary operator in .toResourceBounds()

    @DelevoXDG
    DelevoXDG committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    10c1bc3 View commit details
    Browse the repository at this point in the history

  8. Bump devnet

    @DelevoXDG
    DelevoXDG committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    84c5dde View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Use Cairo 1 accounts for tests to pass

    @DelevoXDG
    DelevoXDG committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    db69dba View commit details
    Browse the repository at this point in the history

  2. Fix #147 (Specify transaction version in test cases names)

    @DelevoXDG
    DelevoXDG committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ee0a9a2 View commit details
    Browse the repository at this point in the history

  3. Add missing segment_arena_builtin to StarknetComputationResources… 

    … and `StarknetExecutionResources`

- Adjust tests
    @DelevoXDG
    DelevoXDG committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    5f87f2c View commit details
    Browse the repository at this point in the history

  4. Add optional executionResources to StarknetL1HandlerTransactionTrace

    @DelevoXDG
    DelevoXDG committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    1ba4133 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Empty

    @DelevoXDG
    DelevoXDG committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    a606158 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Introduce Domain and Revision 

    - Add `StarknetTypedData.Domain`, `StarknetTypedData.Revision`
- Change `domain` type: `[String: Element] -> Domain`
  - Update initializer
- Add `getStructHash(typeName: String, data: Data)`
- Add `getStructHash(domain: Domain)`
    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d2bfbc8 View commit details
    Browse the repository at this point in the history

  2. Add HashMethod enum; Use **poseidon** hash for rev 1 typed data

    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3f0409c View commit details
    Browse the repository at this point in the history

  3. Update encode(dependency) logic in line with rev 1 

    - Use correct escape chars for rev 1
    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    49031c5 View commit details
    Browse the repository at this point in the history

  4. Update encode to take revision into account

    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c681354 View commit details
    Browse the repository at this point in the history

  5. Mark Starknet as @testable in TypedDataTests

    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    58c0c8d View commit details
    Browse the repository at this point in the history

  6. Add rev 1 test case 

    - Rename test files `typed_data_[..].json`-> `typed_data_rev_0_[..].json`
- Add `typed_data_rev_1_example.json`
- Update `TypedDataTests`
  - Move old td cases to `CasesRev0`
  - Add `CasesRev1`
    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4bb69cc View commit details
    Browse the repository at this point in the history

  7. Format

    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a32823d View commit details
    Browse the repository at this point in the history

  8. Review chnages

    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e5f2e71 View commit details
    Browse the repository at this point in the history

  9. Review changes

    @DelevoXDG
    DelevoXDG committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b894924 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Make HashMethod public; Add hash for two elements

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    19e5338 View commit details
    Browse the repository at this point in the history

  2. Add MerkleTree

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    efee210 View commit details
    Browse the repository at this point in the history

  3. Format

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1ac7a1f View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b0d94a2 View commit details
    Browse the repository at this point in the history

  5. Add merkletree to reserved type names

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0006110 View commit details
    Browse the repository at this point in the history

  6. Add MerkleTreeType, StandardType; Convert TypeDeclaration to pr… 

    …otocol

- Add `TypeDeclarationWrapper`
- Change `types` type from `[String: [TypeDeclaration]]` to `[String: [TypeDeclarationWrapper]]`
    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    371fac7 View commit details
    Browse the repository at this point in the history

  7. Move StarknetTypedData.swift to TypedData/StarknetTypedData.swift

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    cb2dd71 View commit details
    Browse the repository at this point in the history

  8. Move TypeDeclaration related extension to TypeDeclaration.swift

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    89c4d7e View commit details
    Browse the repository at this point in the history

  9. Fix TypeDeclarationWrapper decoding of merkletree

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f38cc0d View commit details
    Browse the repository at this point in the history

  10. Support merkletree basic type in StarknetTypedData 

    - Tests
  - Update `typed_data_rev_0_validate_example.json` to contain
  `merkletree`; Update related test cases
  - Add `typed_data_rev_0_struct_merkletree_example.json` and `typed_data_rev_1_felt_merkletree_example.json` and related test cases
    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1d3f8e9 View commit details
    Browse the repository at this point in the history

  11. Split testSignTypedData into rev 0 and 1 tests 

    - Rename `testSignTypedData`->``testSignTypedDataRev0`; Update path to example
- Add `testSignTypedDataRev1`
    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6822784 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1a19f30 View commit details
    Browse the repository at this point in the history

  13. Move build logic to build method

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e330ede View commit details
    Browse the repository at this point in the history

  14. Review changes

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    403bffc View commit details
    Browse the repository at this point in the history

  15. Rename HashMethod->StarknetHashMethod

    @DelevoXDG
    DelevoXDG committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    39f671e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    481872c View commit details
    Browse the repository at this point in the history

  2. Fix build bug post e330ede93f329de682e02a842d5db010a4243758

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a939de5 View commit details
    Browse the repository at this point in the history

  3. Review changes

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1ed2e32 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/159-snip-12

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    495a06e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7206647 View commit details
    Browse the repository at this point in the history

  6. Bump swift version to 5.10.0 

    - Format using `swiftformat`
    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a8eced5 View commit details
    Browse the repository at this point in the history

  7. Bump swift-tools-version to 5.9

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b093f02 View commit details
    Browse the repository at this point in the history

  8. Bump runner from macos-12 to macos-14

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5600de2 View commit details
    Browse the repository at this point in the history

  9. Bump swift version to 5.10.0 

    - Format using `swiftformat`
    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b8390f9 View commit details
    Browse the repository at this point in the history

  10. Bump swift-tools-version to 5.9

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    81fa2f3 View commit details
    Browse the repository at this point in the history

  11. Bump runner from macos-12 to macos-14

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    d8caa2f View commit details
    Browse the repository at this point in the history

  12. Change version to 5.9.0 in .swift-version

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4c27593 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'feat/171-bump-swift-version' into feat/159-snip-12

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5db449a View commit details
    Browse the repository at this point in the history

  14. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e5486a5 View commit details
    Browse the repository at this point in the history

  15. Format

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    2891c5a View commit details
    Browse the repository at this point in the history

  16. Bump version to 5.10.0 

    - Reason: https://github.com/apple/swift-evolution/blob/main/proposals/0404-nested-protocols.md
    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    43fbb0d View commit details
    Browse the repository at this point in the history

  17. Setup Xcode 15.3

    @DelevoXDG
    DelevoXDG committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    04c743c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Rename hash() -> hashArray()

    @DelevoXDG
    DelevoXDG committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ee05381 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    d09d6d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge branch 'feat/171-bump-swift-version' into feat/159-snip-12

    @DelevoXDG
    DelevoXDG authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9feaf94 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    090763c View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Add testEncodeType 

    - Make `encode(type: String)` internal
    @DelevoXDG
    DelevoXDG committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    606a2bf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feat/159-snip-12' of https://github.com/software-mansio… 

    …n/starknet.swift into feat/159-snip-12
    @DelevoXDG
    DelevoXDG committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ddce0c3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3e0a5da View commit details
    Browse the repository at this point in the history

  4. Add merkle tree encodeType tests

    @DelevoXDG
    DelevoXDG committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    8966f27 View commit details
    Browse the repository at this point in the history

  5. Make revision, hashMethod and hashArray() private

    @DelevoXDG
    DelevoXDG committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e2e3002 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    093113d View commit details
    Browse the repository at this point in the history

  2. Make revision public

    @DelevoXDG
    DelevoXDG committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    daf429b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feat/159-snip-12' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    947ebd6 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Make StarknetHashMethod methods public

    @DelevoXDG
    DelevoXDG committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e201759 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/159-2-merkletree

    @DelevoXDG
    DelevoXDG committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0ef4417 View commit details
    Browse the repository at this point in the history

  3. Fix merge anomaly

    @DelevoXDG
    DelevoXDG committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5ebfeac View commit details
    Browse the repository at this point in the history