-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public init
for StarknetFeeEstimate
#198
Add public init
for StarknetFeeEstimate
#198
Conversation
public init(gasConsumed: Felt, gasPrice: Felt, dataGasConsumed: Felt, dataGasPrice: Felt, overallFee: Felt, feeUnit: StarknetPriceUnit) { | ||
self.gasConsumed = gasConsumed | ||
self.gasPrice = gasPrice | ||
self.dataGasConsumed = dataGasConsumed | ||
self.dataGasPrice = dataGasPrice | ||
self.overallFee = overallFee | ||
self.feeUnit = feeUnit | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
Not sure this is absolutely necessary, but maybe it would be reasonable to give option for overallFee
to be automatically calculated based on other arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, good idea.
Co-authored-by: Maksim Zdobnikau <43750648+DelevoXDG@users.noreply.github.com>
Describe your changes
init
forStarknetFeeEstimate
init
forStarknetFeeEstimate
with automaticoverallFee
calculationLinked issues
Closes #197
Breaking changes