Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename combine/dispatch to join/split #247

Closed
propensive opened this issue May 7, 2020 · 0 comments
Closed

rename combine/dispatch to join/split #247

propensive opened this issue May 7, 2020 · 0 comments
Assignees
@propensive
Labels
api enhancement
Milestone
later

Comments

@propensive
Copy link
Collaborator

These methods are quite fundamental, so this will be a trivial, but breaking change. I would like to make this change before v1.0, though.

There is a possibility of having a transition period where we allow the methods to be called either join or combine and split or dispatch.
@propensive propensive added this to the later milestone May 7, 2020
@propensive propensive self-assigned this May 7, 2020
@joroKr21 joroKr21 mentioned this issue Sep 4, 2020
Closed
@adamw adamw mentioned this issue Jul 11, 2021
Closed
6 tasks
@ghost ghost self-assigned this Sep 13, 2021
@Pask423 Pask423 mentioned this issue Sep 14, 2021
Merged
@adamw adamw closed this as completed Sep 23, 2021
rtyley added a commit to scanamo/scanamo that referenced this issue Oct 15, 2021
@rtyley
Update to magnolia v1.0.0-M7
ae51899 
Need to update our Magnolia calls to `combine`/`dispatch` to
`join`/`split`, see:

https://github.com/softwaremill/magnolia/releases/tag/scala2-v1.0.0-M6
softwaremill/magnolia#247
rtyley added a commit to scanamo/scanamo that referenced this issue Oct 15, 2021
@rtyley
Update to magnolia v1.0.0-M7
846983b 
Need to update our Magnolia calls to `combine`/`dispatch` to
`join`/`split`, see:

https://github.com/softwaremill/magnolia/releases/tag/scala2-v1.0.0-M6
softwaremill/magnolia#247
@rtyley rtyley mentioned this issue Oct 15, 2021
Merged
rtyley added a commit to scanamo/scanamo that referenced this issue Oct 26, 2021
@rtyley
Update to magnolia v1.0.0-M7 (#1232)
58b8df0 
Need to update our Magnolia calls to `combine`/`dispatch` to
`join`/`split`, see:

https://github.com/softwaremill/magnolia/releases/tag/scala2-v1.0.0-M6
softwaremill/magnolia#247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@propensive propensive

Labels
api enhancement
Projects
None yet
Milestone
later
Development

No branches or pull requests
2 participants
@adamw @propensive