Added isEnum field to SealedTrait #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
KacperFKorban
requested changes
Aug 9, 2021
src/core/interface.scala
Outdated
| @@ -61,7 +61,8 @@ case class SealedTrait[Typeclass[_], Type] | |||
| (typeInfo: TypeInfo, | |||
| subtypes: IArray[SealedTrait.Subtype[Typeclass, Type, _]], | |||
| annotations: IArray[Any], | |||
| typeAnnotations: IArray[Any]) extends Serializable: | |||
| typeAnnotations: IArray[Any], | |||
| isEnum: Boolean = false) extends Serializable: | |||
There was a problem hiding this comment.
The SealedTrait name can be misleading, it can represent both the sealed hierarchies of sealed traits as well as enums. To implement this issue, a small macro would be needed similar to isObject here:
Line 22 in d8be357
All flags in Quotes API can be found here.
This macro should be used in
magnolia.scala when creating SealedTrait instances.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #319