Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing ThreadLocals on finish to clean up CompileTimeStack. #448

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Removing ThreadLocals on finish to clean up CompileTimeStack. #448

merged 1 commit into from
Jan 14, 2023

Conversation

Caparow
Copy link

@Caparow Caparow commented Jan 13, 2023

This change fixes the issue with the Scala compiler server OOM mentioned in #216 .

@Caparow Caparow mentioned this pull request Jan 13, 2023
Open
joroKr21
joroKr21 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@adamw adamw merged commit b7ee4aa into softwaremill:scala2 Jan 14, 2023
@adamw
Copy link
Member

adamw commented Jan 14, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joroKr21 joroKr21 joroKr21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Caparow @adamw @joroKr21