Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfixes for scala3 #465

Merged
merged 5 commits into from
May 15, 2023
Merged

bugfixes for scala3 #465

merged 5 commits into from
May 15, 2023

Conversation

katlasik
Copy link
Contributor

@katlasik katlasik commented May 5, 2023

  • Fix bug with getting default value for parameters - cast exception is no longer thrown if type is different
  • Fix OtherTests

@katlasik katlasik force-pushed the bugfixes_for_scala3 branch 10 times, most recently from 30bbe68 to 8a55afe Compare May 11, 2023 20:00
@katlasik katlasik force-pushed the bugfixes_for_scala3 branch from 8a55afe to bee8460 Compare May 11, 2023 20:01
adamw
adamw approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@adamw adamw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to separate the reformatting & logic changes into separate PRs (next time :) )

@katlasik katlasik merged commit 27b3822 into scala3 May 15, 2023
@katlasik katlasik deleted the bugfixes_for_scala3 branch May 15, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamw adamw adamw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katlasik @adamw