Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for jdk.internal annotations #495

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

kyri-petrou
Copy link
Contributor

Fixes #493

I haven't added a test for this case since the CI is run on JDK11 only. Do you prefer if I add a test as in the issue repro in the issue above?

@adamw
Copy link
Member

adamw commented Oct 22, 2023

It seems there are some test failures

@kyri-petrou
Copy link
Contributor Author

Oops, seems to have used || instead of && 🤦 It should be good now

@adamw adamw merged commit 18f73e1 into softwaremill:scala3 Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Scala 3] Macro.anns throws IllegalAccessError when used on parameters with Java types on JDK17+
2 participants