fix: consume response entity on response processing failure #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geminicaprograms
force-pushed
the
fix/consume_response_on_failure
branch
from
da8b6b2
to
f72975f
Compare
adamw
reviewed
Sep 8, 2022
akka-http-backend/src/main/scala/sttp/client3/akkahttp/AkkaHttpBackend.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Sep 8, 2022
akka-http-backend/src/main/scala/sttp/client3/akkahttp/AkkaHttpBackend.scala
Outdated
Show resolved
Hide resolved
Issue: When exception is thrown during the response entity processing it may or may not be consumed and as a result the following warning is being displayed in the console: Response entity was not subscribed after 1 second. Make sure to read the response `entity` body or call `entity.discardBytes()` on it -- in case you deal with `HttpResponse`, use the shortcut `response.discardEntityBytes()` Solution: Add handler that takes care of exhausting the response entity when exception is thrown during the response processing. Notes: * the original processing exception is propagated * in case when exception is thrown while the response entity is consumed the original processing exception is propagated Closes #1450
geminicaprograms
force-pushed
the
fix/consume_response_on_failure
branch
from
f72975f
to
9ace351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When exception is thrown during the response entity processing it may or may not be consumed and as a result the following warning is being displayed to the console:
Solution:
Add handler that takes care of exhausting the response entity when exception is thrown during the response processing.
Notes:
Closes #1450