Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status text resolver #1567

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Add status text resolver #1567

merged 2 commits into from
Sep 16, 2022

Conversation

Pask423
Copy link
Contributor

@Pask423 Pask423 commented Sep 15, 2022 •
edited
Loading

closes #1451

@Pask423 Pask423 requested a review from adamw September 15, 2022 18:32
adamw
adamw reviewed Sep 15, 2022
View reviewed changes
core/src/main/scala/sttp/client3/Response.scala Outdated
def ok[T](body: T): Response[T] = apply(body, StatusCode.Ok, "OK")
def ok[T](body: T): Response[T] = apply(body, StatusCode.Ok)

def resolveStatusText(statusCode: StatusCode, provided: String = ""): String =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be private?

@adamw adamw merged commit 332b118 into master Sep 16, 2022
@adamw
Copy link
Member

adamw commented Sep 16, 2022

Thanks :)

@mergify mergify bot deleted the empty-response-body branch September 16, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamw adamw adamw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statusText for Response is always an empty string
2 participants
@Pask423 @adamw