Changes in CI and build.sbt #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2022 22:50
|
Great! I wanted to do that for a long time. This follows how things are done in tapir, right? One thing missing is mergify configuration so that merging steward PR works |
|
Yes, exactly. Sorry I forgot about .mergify config. |
adamw
reviewed
Nov 15, 2022
| - check-success=ci (JS1) | ||
| - check-success=ci (JS2) | ||
| - check-success=ci (Native) | ||
| - check-success=ci (2.12, JVM) |
adamw
reviewed
Nov 15, 2022
build.sbt
Outdated
| lazy val rootProject = (project in file(".")) | ||
| .settings(commonSettings: _*) | ||
| .settings( | ||
| publish / skip := true, | ||
| name := "sttp", | ||
| testJVM := (Test / test).all(filterProject(p => !p.contains("JS") && !p.contains("Native"))).value, | ||
| testJS1 := (Test / test) | ||
| .all(filterProject(p => p.contains("JS") && (p.contains("2_11") || p.contains("2_12")))) | ||
| testJS2_11 := (Test / test) |
There was a problem hiding this comment.
how does this differ from testScoped?
There was a problem hiding this comment.
JS tests are run in different way then others there is a comment in ci file, it works the same way in tapir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.