Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds method and optional status Labels to PrometheusBackend #1651

Merged
merged 15 commits into from
Jan 9, 2023
Merged

Adds method and optional status Labels to PrometheusBackend #1651

merged 15 commits into from
Jan 9, 2023

Commits on Nov 25, 2022

  1. Convert type synonym (tuple) to a class 

    It's easier to understand explicit field names with a class than via the hard-to-follow _.X methods.
    @kevinmeredith
    kevinmeredith committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    23435c9 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Refactor BaseCollectorConfig to support 'builder' method 

    https://stackoverflow.com/questions/74591438/scala-trait-returning-a-sub-type
    @kevinmeredith
    kevinmeredith committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    cfd49d5 View commit details
    Browse the repository at this point in the history

  2. add (if not present) label key-value pairs for method and status

    @kevinmeredith
    kevinmeredith committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    c96598b View commit details
    Browse the repository at this point in the history

  3. update PrometheusBackendTest since all metrics will include method an… 

    …d/or status
    @kevinmeredith
    kevinmeredith committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    1585239 View commit details
    Browse the repository at this point in the history

  4. add code comment

    @kevinmeredith
    kevinmeredith committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    580da36 View commit details
    Browse the repository at this point in the history

  5. add test verifying user-supplied 'method' and 'status' labels are kept

    @kevinmeredith
    kevinmeredith committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    786ad40 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2023

  1. move adding status and method labels to defaults - not always 

    Address softwaremill#1651 (comment)
    @kevinmeredith
    kevinmeredith committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    ec2ca4a View commit details
    Browse the repository at this point in the history

  2. don't add method or status label if already present, case insensitive

    @kevinmeredith
    kevinmeredith committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    e282a4b View commit details
    Browse the repository at this point in the history

  3. class -> case class for RequestCollectors

    @kevinmeredith
    kevinmeredith committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    7870222 View commit details
    Browse the repository at this point in the history

  4. re-name: addLabelPairs -> addMethodStatusLabels

    @kevinmeredith
    kevinmeredith committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    d802a5d View commit details
    Browse the repository at this point in the history

  5. refactor addMethodStatusLabels

    @kevinmeredith
    kevinmeredith committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    2e97286 View commit details
    Browse the repository at this point in the history

  6. Revert "update PrometheusBackendTest since all metrics will include m… 

    …ethod and/or status"

This reverts commit 1585239.
    @kevinmeredith
    kevinmeredith committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    2c8aefc View commit details
    Browse the repository at this point in the history

  7. fix up PrometheusBackendTest per refactor

    @kevinmeredith
    kevinmeredith committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    c5ebc5f View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Fix compile for Scala3

    @adamw
    adamw committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    41efc89 View commit details
    Browse the repository at this point in the history

  2. Split addMethodLabel and addStatusLabel method

    @adamw
    adamw committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    19a2feb View commit details
    Browse the repository at this point in the history