Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http4s: add ember constructor #1742

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Conversation

Fristi
Copy link
Contributor

@Fristi Fristi commented Feb 27, 2023

Ember uses keyed-pool which in turn will support otel4s which allows you track close connection pool metrics. As well Ember will provide a scala native version for which support can be added later.

I've removed the constructors with ExecutionContext as the BlazeClientBuilder says that this constructor is deprecated

Before submitting pull request:

  • Check if the project compiles by running sbt compile
  • Verify docs compilation by running sbt compileDocs
  • Check if tests pass by running sbt test
  • Format code by running sbt scalafmt

@adamw
Copy link
Member

adamw commented Feb 27, 2023

Thanks! MiMA only applies to core, as any libraries or integrations should not depend on concrete backend implementations.

Maybe we should include an optional dependency on ember, then, providing similar convenience methods to create an ember-backed-backend? Or at least providing a copy-pastable example of what to do to create a backend.

@Fristi Fristi changed the title http4s: remove blaze dependency http4s: add ember constructor Mar 1, 2023
@Fristi
Copy link
Contributor Author

Fristi commented Mar 1, 2023

Updated

@adamw adamw merged commit 6c20d1f into softwaremill:master Mar 9, 2023
@adamw
Copy link
Member

adamw commented Mar 9, 2023

Thanks! I've done some adjustments in bc50f9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants