Use -release:11 across for all JVM builds across Scala versions
#1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Does this imply that the Scala Toolkit won't work on Java 8? |
|
@SethTisue It might, though it's not really a question to me :) As far as sttp is concerned, we require Java 11+ for quite some time now (probably a year or so) |
|
@szymon-rd something to document, I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of discussion on this PR.
With this PR, the
-release:11flag is added to all JVM builds for Scala 2.12, 2.13 and 3. Note that I tried to use-release:8for Scala 2.12, but the code wouldn't compile becausecoreuses Java 11 APIs. More info on making on making the compiler flags consistent across Scala versions here