-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1853 empty content-encoding #1855
Conversation
testing/server/src/main/scala/sttp/client3/testing/server/HttpServer.scala
Outdated
Show resolved
Hide resolved
okhttp-backend/monix/src/test/scala/sttp/client3/okhttp/monix/OkHttpMonixHttpTest.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question Shouldn't this be a general filtering of all empty headers, with content-encoding
being just an example? Looks like empty values are generally valid from the point of view of RFC, but pointless anyway. https://stackoverflow.com/a/12131993
@wydra98 ^ see the comment about empty header values @kciesielski I think on the low-level, we should retain whatever is returned from the server; and the |
Before submitting pull request:
sbt compile
sbt compileDocs
sbt test
sbt scalafmt