Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to handle invalid header value using http client zio backend #1856

Merged
merged 11 commits into from
Jun 23, 2023
Merged

No way to handle invalid header value using http client zio backend #1856

merged 11 commits into from
Jun 23, 2023

Conversation

wydra98
Copy link
Contributor

@wydra98 wydra98 commented Jun 15, 2023

  • I am not sure if I should add .catchSomeDefect somewhere else

@wydra98 wydra98 requested a review from adamw June 15, 2023 11:34
@wydra98 wydra98 marked this pull request as ready for review June 15, 2023 11:35
@wydra98 wydra98 marked this pull request as draft June 16, 2023 10:08
@adamw
Copy link
Member

adamw commented Jun 16, 2023

I think the main place this should be added are the proper backends, e.g. HttpClientZioBackend. There, you have to override the send method and add the catching of defects. Also, I think the .resurrect method does exactly this, but in a single line of code.

@wydra98 wydra98 linked an issue Jun 19, 2023 that may be closed by this pull request
No way to handle Invalid header value using HttpClientZioBackend #1823
Closed
@wydra98 wydra98 marked this pull request as ready for review June 19, 2023 07:32
@wydra98 wydra98 marked this pull request as draft June 22, 2023 20:18
@wydra98 wydra98 marked this pull request as ready for review June 23, 2023 05:19
@wydra98 wydra98 requested a review from kciesielski June 23, 2023 05:19
@wydra98 @kciesielski
Update test name
21adf31 
Co-authored-by: Krzysiek Ciesielski <kciesielski@users.noreply.github.com>
@wydra98 wydra98 merged commit 16cb856 into master Jun 23, 2023
@mergify mergify bot deleted the no-way-to-handle-Invalid-header-value-using-HttpClientZioBackend branch June 23, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kciesielski kciesielski kciesielski approved these changes

@adamw adamw Awaiting requested review from adamw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to handle Invalid header value using HttpClientZioBackend
3 participants
@wydra98 @adamw @kciesielski