Improve proxy authentication preventing NPE and allow Basic Authentication (v3) #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DybekK could you add tests for these cases? |
adamw
reviewed
Feb 28, 2024
adamw
approved these changes
Feb 28, 2024
|
@kciesielski I'm not sure if a test using proxies is doable in a reasonable amount of time, but maybe :) @DybekK we'll also need a PR to master w/ the same changes please :) |
DybekK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem described in #2050, where requests sent by
HttpClientBackendto a proxy requiring Basic authentication were failing due to JDK's default settings, resulting in a 407 response and a null body, leading to errors. By removingBasicfromjdk.http.auth.tunneling.disabledSchemes, we now allowHttpClientto use proxy authentication successfully. This behaviour has been documented to guide users on enabling Basic authentication for HTTP tunneling and inform them about security flaws.Additionally, to avoid NPE from null response bodies, we return empty stream.