Skip to content

Commit

Permalink
Do not write SETTINGS in response to ACKs.
Browse files Browse the repository at this point in the history
Reported-by talgendler in Issue #42
  • Loading branch information
soheilhy committed Jan 29, 2018
1 parent 444ce56 commit e09e938
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions matchers.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,11 @@ func matchHTTP2Field(w io.Writer, r io.Reader, name string, matches func(string)

switch f := f.(type) {
case *http2.SettingsFrame:
// Sender acknoweldged the SETTINGS frame. No need to write
// SETTINGS again.
if f.IsAck() {
break
}
if err := framer.WriteSettings(); err != nil {
return false
}
Expand Down

0 comments on commit e09e938

Please sign in to comment.