Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token-js: Add sync version of getAssociatedTokenAddress #3171

Merged
merged 4 commits into from
May 16, 2022
Merged

token-js: Add sync version of getAssociatedTokenAddress #3171

merged 4 commits into from
May 16, 2022

Conversation

dboures
Copy link
Contributor

@dboures dboures commented May 14, 2022

closes #3050

@mergify mergify bot added the community Community contribution label May 14, 2022
@dboures dboures changed the title Add get associated token address sync token-js: Add sync version of getAssociatedTokenAddress May 14, 2022
joncinque
joncinque reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Any chance you can add a test to make sure that both functions produce the same result?

@dboures
Copy link
Contributor Author

dboures commented May 16, 2022

Thanks for the quick review!. The test has been added.

1 similar comment
@dboures
Copy link
Contributor Author

dboures commented May 16, 2022

Thanks for the quick review!. The test has been added.

joncinque
joncinque approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! We just had an issue in the lockfile, which should be resolved. I'll merge this once it passes CI

@dboures
Copy link
Contributor Author

dboures commented May 16, 2022

Ah thanks! I should have taken a closer look at the CI. Now I know for next time

@joncinque
Copy link
Contributor

No worries, it's not clear that it's actually edited by hand 😬

@joncinque joncinque merged commit 49c53ad into solana-labs:master May 16, 2022
@joncinque
Copy link
Contributor

Thanks for your contribution!

@charlie-amihan
Copy link

Thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

token-js: Add sync version of getAssociatedTokenAddress
3 participants
@dboures @joncinque @charlie-amihan