refactor(experimental): a transport that coalesces multiple subscript…

…ions behind a single subscription
solana-labs · Sep 29, 2023 · c80a372 · c80a372
1 parent 7c09215
commit c80a372
Show file tree

Hide file tree

Showing 6 changed files with 459 additions and 78 deletions.
diff --git a/packages/library/package.json b/packages/library/package.json
@@ -71,8 +71,7 @@
         "@solana/keys": "workspace:*",
         "@solana/rpc-core": "workspace:*",
         "@solana/rpc-transport": "workspace:*",
-        "@solana/transactions": "workspace:*",
-        "fast-stable-stringify": "^1.0.0"
+        "@solana/transactions": "workspace:*"
     },
     "devDependencies": {
         "@solana/eslint-config-solana": "^1.0.2",

diff --git a/packages/library/src/__tests__/rpc-request-deduplication-test.ts b/packages/library/src/__tests__/rpc-request-deduplication-test.ts
@@ -1,7 +1,4 @@
-import {
-    getSolanaRpcPayloadDeduplicationKey,
-    getSolanaRpcSubscriptionPayloadDeduplicationKey,
-} from '../rpc-request-deduplication';
+import { getSolanaRpcPayloadDeduplicationKey } from '../rpc-request-deduplication';
 
 describe('getSolanaRpcPayloadDeduplicationKey', () => {
     it('produces no key for undefined payloads', () => {
@@ -55,66 +52,3 @@ describe('getSolanaRpcPayloadDeduplicationKey', () => {
         );
     });
 });
-
-describe('getSolanaRpcSubscriptionPayloadDeduplicationKey', () => {
-    it('produces no key for undefined payloads', () => {
-        expect(getSolanaRpcSubscriptionPayloadDeduplicationKey(undefined)).toBeUndefined();
-    });
-    it('produces no key for null payloads', () => {
-        expect(getSolanaRpcSubscriptionPayloadDeduplicationKey(null)).toBeUndefined();
-    });
-    it('produces no key for array payloads', () => {
-        expect(getSolanaRpcSubscriptionPayloadDeduplicationKey([])).toBeUndefined();
-    });
-    it('produces no key for string payloads', () => {
-        expect(getSolanaRpcSubscriptionPayloadDeduplicationKey('o hai')).toBeUndefined();
-    });
-    it('produces no key for numeric payloads', () => {
-        expect(getSolanaRpcSubscriptionPayloadDeduplicationKey(123)).toBeUndefined();
-    });
-    it('produces no key for bigint payloads', () => {
-        expect(getSolanaRpcSubscriptionPayloadDeduplicationKey(123n)).toBeUndefined();
-    });
-    it('produces no key for object payloads that are not JSON-RPC payloads', () => {
-        expect(getSolanaRpcSubscriptionPayloadDeduplicationKey({})).toBeUndefined();
-    });
-    it("produces a key for a JSON-RPC payload whose method ends in 'Subscribe'", () => {
-        expect(
-            getSolanaRpcSubscriptionPayloadDeduplicationKey({
-                id: 1,
-                jsonrpc: '2.0',
-                method: 'fooSubscribe',
-                params: 'foo',
-            })
-        ).toMatchInlineSnapshot(`"["fooSubscribe","foo"]"`);
-    });
-    it("produces no key for a JSON-RPC payload whose method does not end in 'Subscribe'", () => {
-        expect(
-            getSolanaRpcSubscriptionPayloadDeduplicationKey({
-                id: 1,
-                jsonrpc: '2.0',
-                method: 'getFoo',
-                params: 'foo',
-            })
-        ).toBeUndefined();
-    });
-    it('produces identical keys for two materially identical JSON-RPC payloads', () => {
-        expect(
-            getSolanaRpcSubscriptionPayloadDeduplicationKey({
-                id: 1,
-                jsonrpc: '2.0',
-                method: 'fooSubscribe',
-                params: { a: 1, b: { c: [2, 3], d: 4 } },
-            })
-        ).toEqual(
-            /* eslint-disable sort-keys-fix/sort-keys-fix */
-            getSolanaRpcSubscriptionPayloadDeduplicationKey({
-                jsonrpc: '2.0',
-                method: 'fooSubscribe',
-                params: { b: { d: 4, c: [2, 3] }, a: 1 },
-                id: 2,
-            })
-            /* eslint-enable sort-keys-fix/sort-keys-fix */
-        );
-    });
-});