fix: update to 7.5.1 of rpc-websockets; fixes socket state corruption related to automatic reconnections
#1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on related to automatic reconnections
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
+ Coverage 76.22% 76.35% +0.12%
==========================================
Files 56 56
Lines 3151 3151
Branches 475 475
==========================================
+ Hits 2402 2406 +4
+ Misses 582 578 -4
Partials 167 167
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
🎉 This PR is included in version 1.73.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At long last, we've found a clear-cut source of socket state corruption in
rpc-websocketsand were able to fix it in elpheria/rpc-websockets#138.This pulls the new version into
@solana/web3.js. Now, when our library make an explicit reconnection attempt, it will no longer cause the socket state to get corrupted byrpc-websocket'simplicit reconnection machinery.Fixes #1106.