Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of SerializedMessageBytesBase64 and TransactionVersion #2493

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mcintyre94
Copy link
Collaborator

@mcintyre94 mcintyre94 commented Apr 16, 2024

  • New type TransactionMessageBytesBase64 in Transactions
  • Replace TransactionVersion with NewTransactionVersion

This removes the need to export this types file from Transactions.

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: d9e6623

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcintyre94 mcintyre94 marked this pull request as ready for review April 16, 2024 13:18
@mcintyre94
Copy link
Collaborator Author

Bah I thought I might be able to get away with a rpc-types -> transaction-messages dependency with it being simpler, but nope! Added back the TransactionVersion type to rpc-types.

@mcintyre94 mcintyre94 force-pushed the tx-refactor-types-usages branch 2 times, most recently from 70593e7 to 01a23d0 Compare April 16, 2024 13:28
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

Copy link

socket-security bot commented Apr 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@swc/jest@0.2.36 filesystem Transitive: environment, shell +4 435 kB kdy1
npm/@types/bn.js@5.1.5 None +1 4.01 MB types
npm/@types/bs58@4.0.1 None +1 12.4 kB types
npm/@types/chai-as-promised@7.1.8 None 0 26.1 kB types
npm/@types/chai@4.3.5 None 0 77.2 kB types
npm/@types/express-serve-static-core@4.17.43 None +4 72.2 kB types
npm/@types/fastestsmallesttextencoderdecoder@1.0.2 None 0 5.37 kB types
npm/@types/jest@29.5.12 Transitive: environment, filesystem +21 722 kB types
npm/@types/mocha@10.0.6 None 0 95.6 kB types
npm/@types/mz@2.7.4 None +1 4.08 MB types
npm/@types/node-fetch@2.1.0 None +1 4.01 MB types
npm/@types/node@18.19.21 None 0 3.89 MB types
npm/@types/sinon-chai@3.2.12 None 0 6.53 kB types
npm/@types/sinon@10.0.16 None +1 93.9 kB types
npm/@types/ws@8.5.10 None +1 4.02 MB types
npm/@typescript-eslint/eslint-plugin@6.21.0 Transitive: environment, filesystem +25 6.44 MB jameshenry
npm/@typescript-eslint/parser@6.8.0 Transitive: environment, filesystem +18 1.73 MB jameshenry
npm/agadoo@3.0.0 None +2 511 kB rich_harris
npm/bigint-buffer@1.1.5 Transitive: environment, filesystem +2 75 kB no2chem
npm/borsh@0.7.0 None 0 34.6 kB volovyk-s
npm/browserslist-to-esbuild@2.1.1 Transitive: environment, filesystem +3 2.34 MB marcofugaro
npm/bs58@4.0.1 None +1 13.9 kB dcousens
npm/chai-as-promised@7.1.1 None +1 47.8 kB domenic
npm/chai@4.3.7 None +4 812 kB chai
npm/commitlint@19.2.1 Transitive: environment, eval, filesystem, shell, unsafe +41 1.83 MB escapedcat
npm/cross-env@7.0.3 environment Transitive: filesystem, shell +1 50.3 kB kentcdodds
npm/dataloader@2.2.2 None 0 62.2 kB saihaj
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-config-turbo@1.12.4 Transitive: environment, eval, filesystem, shell +2 508 kB turbobot
npm/eslint-plugin-import@2.29.0 filesystem, unsafe Transitive: environment, eval +45 4.19 MB ljharb
npm/eslint-plugin-jest@27.9.0 filesystem Transitive: environment +26 3.19 MB simenb
npm/eslint-plugin-mocha@10.1.0 None +2 467 kB lo1tuma
npm/eslint-plugin-prettier@5.1.3 None 0 33.9 kB jounqin
npm/eslint-plugin-react-hooks@4.6.0 environment 0 118 kB gnoff
npm/eslint-plugin-simple-import-sort@10.0.0 None 0 37.3 kB lydell
npm/eslint-plugin-sort-keys-fix@1.1.2 None +5 1.46 MB leo-buneev
npm/eslint-plugin-typescript-sort-keys@3.2.0 Transitive: environment, filesystem +27 2.92 MB infctr
npm/eslint@8.57.0 environment, filesystem Transitive: eval, shell, unsafe +44 8.9 MB eslintbot
npm/esm@3.2.25 eval, filesystem, unsafe 0 309 kB jdalton
npm/fastestsmallesttextencoderdecoder@1.0.22 None 0 43.4 kB anonyco
npm/graphql@16.8.1 None 0 1.34 MB i1g
npm/jayson@4.1.0 network Transitive: filesystem, shell +9 1.36 MB tedeh
npm/jest-dev-server@10.0.0 environment Transitive: filesystem, shell +11 302 kB neoziro
npm/jest-environment-jsdom@30.0.0-alpha.3 Transitive: eval +19 1.81 MB simenb

🚮 Removed packages: npm/mz@2.7.0, npm/tslib@2.6.2

View full report↗︎

Copy link

socket-security bot commented Apr 18, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/@swc/core@1.3.93
  • Install script: postinstall
  • Source: node postinstall.js
Install scripts npm/bigint-buffer@1.1.5
  • Install script: install
  • Source: npm run rebuild || echo "Couldn't build bindings. Non-native version used."
Install scripts npm/esbuild@0.19.7
  • orphan: npm/esbuild@0.19.7

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@swc/core@1.3.93
  • @SocketSecurity ignore npm/bigint-buffer@1.1.5
  • @SocketSecurity ignore npm/esbuild@0.19.7

Base automatically changed from tx-clean-exports to master April 18, 2024 06:39
- New type TransactionMessageBytesBase64 in Transactions
- Replace TransactionVersion with NewTransactionVersion
@mcintyre94
Copy link
Collaborator Author

Ignoring the socket security error - the only dependency changes here are adding @solana/transaction-messages as a dependency to some libraries.

@mcintyre94 mcintyre94 merged commit efe04f4 into master Apr 18, 2024
7 of 8 checks passed
@mcintyre94 mcintyre94 deleted the tx-refactor-types-usages branch April 18, 2024 07:29
Copy link
Contributor

🎉 This PR is included in version 1.91.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented May 3, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants