fix: Rewrite the message printer as a parser to avoid problems with regexes in old browsers #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9e17228 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
…egexes in old browsers
steveluscher
force-pushed
the
message-printer-parser-version
branch
from
a93e0bd
to
bc06449
Compare
steveluscher
added
the
automerge
Graphite App
steveluscher
removed
the
automerge
steveluscher
added
the
automerge
|
🎉 This PR is included in version 1.92.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
thank you sir 🫡 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@C-o-d-e-C-o-w-b-o-y and @lukecaan noticed that negative lookbehinds crash old versions of Safari (#2745).
This PR reimplements the message printer as a parser.
Test plan