Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reafactor(Agave 2.0): Remove All Instances of getFees and getFeeCalculatorForBlockhash #2896

Closed

Conversation

0xIchigo
Copy link
Contributor

This PR aims to start addressing #2859 by eliminating all instances of getFees and getFeeCalculatorForBlockhash as they'll be removed in Agave 2.0

Copy link

changeset-bot bot commented Jun 29, 2024

⚠️ No Changeset found

Latest commit: 3f853aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Jun 29, 2024
@mergify mergify bot requested a review from a team June 29, 2024 06:17
@steveluscher
Copy link
Collaborator

Thanks for this!

Before you go too far down this rabbit hole, I've started to have a few second thoughts here.

  1. Responsibly removing these methods would require a major version bump, which would take legacy web3.js to 2.0.
  2. The new library that we actually intend on releasing as web3.js 2.0 already has these methods gone.

I think maybe we just cut our losses for legacy, and close #2859 by releasing the new library. Two birds, one stone.

@0xIchigo
Copy link
Contributor Author

0xIchigo commented Jul 1, 2024

No worries @steveluscher! I figured I'd start with this PR and go from there. Should I close this PR then or leave it open for the time being?

@github-actions github-actions bot added the stale label Jul 15, 2024
@github-actions github-actions bot closed this Jul 23, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants