fix more shellcheck

solana-labs · Jun 23, 2018 · 2a93bd0 · 2a93bd0
1 parent 13773b5
commit 2a93bd0
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/multinode-demo/myip.sh b/multinode-demo/myip.sh
@@ -2,10 +2,16 @@
 
 function myip()
 {
-  declare ipaddrs=(
-    $(curl -s ifconfig.co)                             # query interwebs
-    $(ifconfig | awk '/inet(6)? (addr:)?/ {print $2}') # machine interfaces
-  )
+  declare ipaddrs=( )
+
+  # query interwebs
+  mapfile -t ipaddrs < <(curl -s ifconfig.co)
+
+  # machine's interfaces
+  mapfile -t -O "${#ipaddrs[*]}" ipaddrs < \
+          <(ifconfig | awk '/inet(6)? (addr:)?/ {print $2}')
+
+  ipaddrs=( "${extips[@]}" "${ipaddrs[@]}" )
 
   if (( ! ${#ipaddrs[*]} ))
   then