sdk: add bounds check when instantiating Keypair from byte array (#…

…34817)
solana-labs · Jan 18, 2024 · 6dbcdc0 · 6dbcdc0
1 parent 0e8f2de
commit 6dbcdc0
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/sdk/src/signer/keypair.rs b/sdk/src/signer/keypair.rs
@@ -44,6 +44,11 @@ impl Keypair {
 
     /// Recovers a `Keypair` from a byte array
     pub fn from_bytes(bytes: &[u8]) -> Result<Self, ed25519_dalek::SignatureError> {
+        if bytes.len() < ed25519_dalek::KEYPAIR_LENGTH {
+            return Err(ed25519_dalek::SignatureError::from_source(String::from(
+                "candidate keypair byte array is too short",
+            )));
+        }
         let secret =
             ed25519_dalek::SecretKey::from_bytes(&bytes[..ed25519_dalek::SECRET_KEY_LENGTH])?;
         let public =