test: add test to ensure backwards compatibility

solana-labs · Feb 17, 2022 · 8260d8d · 8260d8d
1 parent f476158
commit 8260d8d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/web3.js/src/publickey.ts b/web3.js/src/publickey.ts
@@ -212,7 +212,7 @@ export class PublicKey extends Struct {
    * Async version of findProgramAddressSync
    * For backwards compatibility
    */
-   static async findProgramAddress(
+  static async findProgramAddress(
     seeds: Array<Buffer | Uint8Array>,
     programId: PublicKey,
   ): Promise<[PublicKey, number]> {

diff --git a/web3.js/test/publickey.test.ts b/web3.js/test/publickey.test.ts
@@ -200,6 +200,12 @@ describe('PublicKey', function () {
         ),
       ).to.be.true;
     }
+
+    // Should work in promise mode, for backwards compatibility
+    PublicKey.createProgramAddress(
+      [Buffer.from('', 'utf8'), Buffer.from([1])],
+      programId,
+    ).then();
   });
 
   it('findProgramAddress', async () => {
@@ -218,6 +224,9 @@ describe('PublicKey', function () {
         ),
       ),
     ).to.be.true;
+
+    // Should work in promise mode, for backwards compatibility
+    PublicKey.findProgramAddress([Buffer.from('', 'utf8')], programId).then();
   });
 
   it('isOnCurve', () => {
@@ -246,4 +255,4 @@ describe('PublicKey', function () {
     const decoded = PublicKey.decodeUnchecked(encoded);
     expect(decoded.equals(publicKey)).to.be.true;
   });
-});
+});