Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug why there are large storage accounts on testnet and devnet (inflation related?) #10870

Closed
mvines opened this issue Jul 1, 2020 · 6 comments · Fixed by #11996
Closed
Milestone

Comments

@mvines
Copy link
Member

mvines commented Jul 1, 2020

http://explorer.solana.com/supply?cluster=devnet (for devnet; this isn't happening anymore) http://explorer.solana.com/supply?cluster=testnet (for testnet) displays:
image
which doesn't really make sense.

Are these accounts just legacy from before the storage program was removed? Lets:

  1. Fully understand where they came from (testnet doesn't maintain a ledger history on GCE, but we do have devnet history so it's possible to search older snapshots if needed)
  2. Ensure this can't happen on mainnet-beta !
  3. Consider removing these accounts by manually creating a new snapshot without them and hard forking devnet and testnet
@mvines mvines added this to the v1.3.0 milestone Jul 1, 2020
@rwalker-com
Copy link
Contributor

rwalker-com commented Jul 1, 2020

reward pools were initially created with infinite tokens, they were populated during genesis by stake/storage program code, and were excepted from any "total tokens" calculations

now, it looks like tokens are manufactured from thin air here:
https://github.com/solana-labs/solana/blob/master/programs/stake/src/stake_state.rs#L852 ?

does the system program except the stake program from scarcity rules, now?

edit: nevermind, forgot that this logic moved to runtime for stakes. I don't think that ever happened for storage.

@sakridge
Copy link
Member

sakridge commented Jul 1, 2020

These are back at slot 15,754,919

5Wwq3cCpHzEMoQifq7yDXJC1RfdbKQS8sgWSCvq3rJP:
  - balance: 18446744073.709553 SOL
  - owner: 'Storage111111111111111111111111111111111111'
  - executable: false
  - data: '5Sxr3'
  - data_len: 4
13pnsN5WU8B4qBfSXUJ1P3apmYnk7uk7J4hVbNgCpPh4:
  - balance: 18446744073.709553 SOL
  - owner: 'Storage111111111111111111111111111111111111'
  - executable: false
  - data: '5Sxr3'
  - data_len: 4

So, doesn't seem to be a new occurrence.

@sakridge
Copy link
Member

sakridge commented Jul 2, 2020

Seems that this would have created these 32 storage reward pool accounts:

https://github.com/solana-labs/solana/blob/3415db9739f429f7efda7b0aec6c1d6458ae6b88/programs/storage/src/rewards_pools.rs

@rwalker-com
Copy link
Contributor

yeah, but adding each of these to capitalization would result in capitalization moving in a negative direction (-32 to be exact ;) ). I expect that initial bank and genesis had capitalization right.

@mvines mvines modified the milestones: v1.3.0, v1.4.0 Aug 5, 2020
@ryoqun
Copy link
Member

ryoqun commented Sep 2, 2020

Oh, maybe I'm going to fix this at #11996 :)

@ryoqun
Copy link
Member

ryoqun commented Sep 8, 2020

Fix confirmed:

image

$ ./target/release/solana epoch-info --url http://testnet.solana.com 

Block height: 28309720
Slot: 34672025
Epoch: 93
Epoch Slot Range: [34652256..35084256)
Epoch Completed Percent: 4.576%
Epoch Completed Slots: 19769/432000 (412231 remaining)
Epoch Completed Time: 2h 11m 47s/2days (1day 21h 48m 12s remaining)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants