Purge storage rewards from accounts db for testnet #11996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Sep 2, 2020
| // never do this for testnet; we're pristine here. :) | ||
| OperatingMode::Development => false, | ||
| // schedule to remove at testnet/tds | ||
| OperatingMode::Preview => self.epoch() == 93, |
There was a problem hiding this comment.
Let's this done rather quickly, otherwise we can't land #11927
mvines
reviewed
Sep 2, 2020
mvines
previously approved these changes
Sep 3, 2020
There was a problem hiding this comment.
If we're going to roll this out on testnet epoch 93, please speed up this activation to 93 as well!
Line 3289 in af08221
ryoqun
force-pushed
the
purge-storage-from-testnet
branch
from
dbed1b6 to
7f5c09a
Compare
Codecov Report
@@ Coverage Diff @@
## master #11996 +/- ##
=======================================
Coverage 82.1% 82.2%
=======================================
Files 334 334
Lines 78643 78692 +49
=======================================
+ Hits 64639 64693 +54
+ Misses 14004 13999 -5 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2020
* Purge storage rewards from accounts db for testnet * Fix test failing only on stable (cherry picked from commit fb71ee6)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
current capitalization calculation has an edge-case bug (it ignores overflowing). And testnet has bogus deprecated accounts still (storage reward pools for archiver).
With both combined, this skewed the capitalization for testnet....
Summary of Changes
Eradicate old-age vestigial accounts entirely and adjust the skewed capitalization to pave a way for cleaner new cap. calculation & enforcement at #11927.
I largely copied from #11966 ;)
Context
This blocks #11927.
Fixes #10870