Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review code for ignored errors #155

Closed
garious opened this issue Apr 26, 2018 · 4 comments
Closed

Review code for ignored errors #155

garious opened this issue Apr 26, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@garious
Copy link
Contributor

garious commented Apr 26, 2018

Rust will warn us if we ignore a Result<T>, but not a Vec<Result<T>>.

@sakridge spotted an instance of that in process_verified_events(). Are there others?
@garious garious added the good first issue Good for newcomers label Apr 27, 2018
@jackson-sandland
Copy link
Contributor

@garious how do you find these warnings?

@garious
Copy link
Contributor Author

garious commented May 16, 2018

The compiler won't raise a warning unless the return value is Result. So git grep 'Vec<Result' is probably your best bet.

@garious
Copy link
Contributor Author

garious commented Jun 15, 2018

We're in good shape here. Closing this ticket.

@garious garious closed this as completed Jun 15, 2018
@garious
Copy link
Contributor Author

garious commented Jun 23, 2018

FYI, as of 1.27.0, one can add #[must_use] to ensure a return value, such as Vec<Result<T>> is used.

vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@CriesofCarrots
Bump sdk version, and adjust accordingly (solana-labs#155)
019235c
steviez pushed a commit to steviez/solana that referenced this issue Mar 8, 2024
@jstarry
Use agave prefix in scripts for pre-installed binaries (solana-labs#155)
68be105
willhickey pushed a commit that referenced this issue Mar 9, 2024
@jstarry @willhickey
Use agave prefix in scripts for pre-installed binaries (#155)
3cba072
willhickey added a commit that referenced this issue Mar 11, 2024
@willhickey
Revert "Use agave prefix in scripts for pre-installed binaries (#155)"
a8e2540 
This reverts commit 3cba072.
stevenbooke pushed a commit to stevenbooke/solana that referenced this issue Mar 18, 2024
@willhickey @stevenbooke
Revert "Use agave prefix in scripts for pre-installed binaries (solan…
be0bf74 
…a-labs#155)"

This reverts commit 3cba072.
lijunwangs pushed a commit to lijunwangs/solana that referenced this issue Mar 21, 2024
@mergify @jstarry
[anza migration] v1.17: Use agave prefix in scripts for pre-installed…
6234bc9 
… binaries (backport of solana-labs#155) (solana-labs#349)

Use agave prefix in scripts for pre-installed binaries (solana-labs#155)

(cherry picked from commit 68be105)

Co-authored-by: Justin Starry <justin@anza.xyz>
apfitzge referenced this issue in apfitzge/agave Mar 21, 2024
@mergify @jstarry
[anza migration] v1.18: Use agave prefix in scripts for pre-installed…
79678fd 
… binaries (backport of anza-xyz#155) (anza-xyz#350)

Use agave prefix in scripts for pre-installed binaries (anza-xyz#155)

(cherry picked from commit 68be105)

Co-authored-by: Justin Starry <justin@anza.xyz>
palinko91 pushed a commit to palinko91/solana that referenced this issue May 7, 2024
@willhickey @palinko91
Revert "Use agave prefix in scripts for pre-installed binaries (solan…
074fda9 
…a-labs#155)"

This reverts commit 3cba072.
palinko91 pushed a commit to palinko91/solana that referenced this issue May 7, 2024
@willhickey @palinko91
Revert "Use agave prefix in scripts for pre-installed binaries (solan…
d488e67 
…a-labs#155)"

This reverts commit 3cba072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garious @jackson-sandland