Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving criterion benchmarks back to libtest #725

Closed
garious opened this issue Jul 21, 2018 · 1 comment
Closed

Consider moving criterion benchmarks back to libtest #725

garious opened this issue Jul 21, 2018 · 1 comment
Assignees

Comments

@garious
Copy link
Contributor

garious commented Jul 21, 2018

Devs are not seeing good ROI on Criterion, and would prefer to keep cargo watch -x bench running as fast as possible. We should consider one of:

  • moving the benchmarks in the benches folder back to libtest
  • add a flag that runs them with libtest by default and optionally runs them with Criterion for improved precision
  • make libtest and criterion benches coexist, but the criterion ones only added to the build when a flag is present (i.e. --features=criterion).
@garious garious self-assigned this Aug 20, 2018
@garious garious added this to the v0.8.0 milestone Aug 20, 2018
@garious
Copy link
Contributor Author

garious commented Sep 5, 2018

Fixed in #1032. After RustConf, it became clear that we don't need both benchmarking suites to coexist, that criterion is just too heavyweight.

And that benchcmp gives us the dev workflow that made criterion so appealing: https://github.com/BurntSushi/cargo-benchcmp

@garious garious closed this as completed Sep 5, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
Bumps [eslint](https://github.com/eslint/eslint) from 7.11.0 to 7.12.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.11.0...v7.12.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Lichtso pushed a commit to Lichtso/solana that referenced this issue Apr 12, 2024
buffalojoec pushed a commit to buffalojoec/solana that referenced this issue Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant