Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce background stale AppendVec shrink mechanism (bp #9219) #10029

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 13, 2020

This is an automated backport of pull request #9219 done by Mergify

Cherry-pick of b28ec43 has failed:

On branch mergify/bp/v1.0/pr-9219
Your branch is up to date with 'origin/v1.0'.

You are currently cherry-picking commit b28ec430e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   runtime/src/append_vec.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	added by them:   core/src/accounts_background_service.rs
	both modified:   core/src/lib.rs
	both modified:   core/src/tvu.rs
	both modified:   runtime/src/accounts_db.rs
	both modified:   runtime/src/bank/mod.rs

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the simulator.

Finally, you can contact us on https://mergify.io/

* Introduce background AppendVec shrink mechanism

* Support ledger tool

* Clean up

* save

* save

* Fix CI

* More clean up

* Add tests

* Clean up yet more

* Use account.hash...

* Fix typo....

* Add comment

* Rename accounts_cleanup_service

(cherry picked from commit b28ec43)

# Conflicts:
#	core/src/accounts_background_service.rs
#	core/src/lib.rs
#	core/src/tvu.rs
#	runtime/src/accounts_db.rs
#	runtime/src/bank/mod.rs
@mergify mergify bot added conflicts automerge Merge this Pull Request automatically once CI passes labels May 13, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label May 13, 2020
@ryoqun
Copy link
Member

ryoqun commented May 14, 2020

context: this is nice-to-have (not mandatory, rather companion with #9527) perf improvement for mainnet-beta... I'm thinking to backport this depending on the required backporting woce

@ryoqun
Copy link
Member

ryoqun commented May 15, 2020

@ryoqun ryoqun closed this May 15, 2020
@mergify mergify bot deleted the mergify/bp/v1.0/pr-9219 branch May 15, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants