-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use serde provided serialization for atomics #10096
Use serde provided serialization for atomics #10096
Conversation
… functionality already provided by serde
horray for working on this quickly! @svenski123 it seems that our ci doesn't like empty files... I think this file can just completely go away and put snapshot versioned code in |
Ah, also if you're bothered with rebasing in general. Please feel free to to any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really thank you!
Codecov Report
@@ Coverage Diff @@
## master #10096 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 283 282 -1
Lines 65930 65904 -26
=======================================
- Hits 53785 53765 -20
+ Misses 12145 12139 -6 |
Use serde provided functions for serializing / deserializing atomics instead of the functions in serde_utils which are functionally equivalent.
Remove unused functions in serde_utils.
Note serde_utils.rs is left as an empty file for other PRs that will add to it.