[wip] Gpu rebase inprog #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split out processing into a separate thread closer wip update wip update ffi wip wip wip wip update wip wip wip wip builds! update s/packet_size/packet_data_size/g wip s/packet_size/packet_data_size dont sigverify tx as well split sig and plan verify update update update build update 256 packet limit per batch try sending less then 256 to process
garious
reviewed
Apr 4, 2018
| @@ -0,0 +1,8 @@ | |||
| fn main() { | |||
There was a problem hiding this comment.
What happens if the user doesn't have cuda libs installed or doesn't want to install them?
There was a problem hiding this comment.
Seems like we can have something like: if !env::var("CARGO_CFG_CUDA").is_err() { prints... }
if we have a cfg like this:
#[cfg(cuda)] => CARGO_CFG_CUDA
garious
reviewed
Apr 4, 2018
| @@ -47,7 +47,7 @@ impl Event { | |||
| /// spending plan is valid. | |||
| pub fn verify(&self) -> bool { | |||
| match *self { | |||
| Event::Transaction(ref tr) => tr.verify(), | |||
| Event::Transaction(ref tr) => tr.plan_verify(), | |||
There was a problem hiding this comment.
You should not have needed to make this change. I took verify() out of skel's codepath.
garious
reviewed
Apr 4, 2018
| @@ -11,7 +11,7 @@ use std::sync::atomic::AtomicBool; | |||
| use std::sync::{Arc, Mutex}; | |||
|
|
|||
| fn main() { | |||
| let addr = "127.0.0.1:8000"; | |||
| let addr = "127.0.0.1:9000"; | |||
garious
reviewed
Apr 4, 2018
| @@ -8,12 +8,17 @@ use rayon::prelude::*; | |||
| use signature::{KeyPair, KeyPairUtil, PublicKey, Signature, SignatureUtil}; | |||
|
|
|||
| #[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Clone)] | |||
| pub struct Transaction { | |||
| pub struct Signed { | |||
There was a problem hiding this comment.
Last review asked that you change this to TransactionData and that you remove 'from' from it.
|
ugh, a separate PR for a rebase? This throws away all the comments I made on the previous one. |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
Bumps [react-bootstrap](https://github.com/react-bootstrap/react-bootstrap) from 1.0.0 to 1.1.1. - [Release notes](https://github.com/react-bootstrap/react-bootstrap/releases) - [Changelog](https://github.com/react-bootstrap/react-bootstrap/blob/master/CHANGELOG.md) - [Commits](react-bootstrap/react-bootstrap@v1.0.0...v1.1.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need some help with the borrow checker :)