Reject old transactions so that we can boot old signatures #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, a client could put any value into `last_id` and was primarily there to ensure the transaction had a globally unique signature. With this patch, the server can use `last_id` as an indicator of how long its been since the transaction was created. The server may choose to reject sufficiently old transactions so that it can forget about old signatures.
Reject old transactions so that we can calculate an upper bound for memory usage, and therefore ensure the server won't slow down over time to crash due to memory exhaustion.
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 96.05% 96.09% +0.04%
==========================================
Files 16 16
Lines 1344 1358 +14
==========================================
+ Hits 1291 1305 +14
Misses 53 53
Continue to review full report at Codecov.
|
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
Bumps [flow-bin](https://github.com/flowtype/flow-bin) from 0.128.0 to 0.129.0. - [Release notes](https://github.com/flowtype/flow-bin/releases) - [Commits](https://github.com/flowtype/flow-bin/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AshwinSekar
pushed a commit
to AshwinSekar/solana
that referenced
this pull request
Mar 6, 2024
…-labs#108) CI: Checkout v1.17 branch from SPL for downstream job
willhickey
pushed a commit
that referenced
this pull request
Mar 9, 2024
CI: Checkout v1.17 branch from SPL for downstream job
segfaultdoc
pushed a commit
to jito-labs/solana
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject old transactions so that we can calculate an upper bound for memory usage, and therefore ensure the server won't slow down over time to crash due to memory exhaustion.
This is also a handy feature for the clients. A client can't tell if their transaction was dropped or if it were bumped into a mempool for later execution. The feature lets the client know for sure that if their transaction doesn't show up on the ledger after a known number of entries, those funds can safely be spent elsewhere.