Fix skipped slot detection for eager rent collect #10890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10890 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 308 308
Lines 71447 71468 +21
=======================================
+ Hits 58513 58549 +36
+ Misses 12934 12919 -15 |
ryoqun
changed the title
ryoqun
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
stale
bot
removed
the
stale
ryoqun
commented
Jul 9, 2020
| vec![(14, 31, 32), (0, 0, 64)] | ||
| ); | ||
| bank = Arc::new(new_from_parent(&bank)); | ||
| assert_eq!(bank.rent_collection_partitions(), vec![(0, 1, 64)]); |
There was a problem hiding this comment.
I know this is rather untasteful hard coding magic numbers. But, I want to first fix the bug and deploy the updated logic to tds along with #10206.
|
@sakridge Oops, I intended to ask a review from you but it seems that I wrongly assigned this pr to you.... ;) |
mergify bot
pushed a commit
that referenced
this pull request
Jul 9, 2020
(cherry picked from commit f1c1152)
ryoqun
added a commit
that referenced
this pull request
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sorry, skipped slot detection was half-way for eager-rent collection... Found today with tds's epoch 61 -> epoch 62 transition:
Bad (curent behavior; missing last pubkey range for previous epoch):
Summary of Changes
Correctly detect it.... Also adjust gating a bit. I think tweaking gated logic is safe because it's still not scheduled.
Good (future behavior; adding last pubkey range for previous epoch):
follow-up to #10206.
CC: @t-nelson FYI: @mvines