generate_pull_response optimization #11597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
generate_pull_opt
branch
from
473ebf2 to
23e750c
Compare
aeyakovenko
previously approved these changes
Aug 12, 2020
sakridge
force-pushed
the
generate_pull_opt
branch
from
23e750c to
1a3281b
Compare
mergify
bot
dismissed
aeyakovenko’s stale review
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #11597 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 330 330
Lines 75886 75905 +19
=======================================
+ Hits 62283 62305 +22
+ Misses 13603 13600 -3 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2020
(cherry picked from commit f519fde)
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2020
(cherry picked from commit f519fde) # Conflicts: # core/src/crds_gossip_pull.rs
This was referenced Dec 15, 2021
This was referenced May 23, 2023
This was referenced Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lots of duplicate work done in the inner loop of generate_pull_responses.
Summary of Changes
Hoist work related to mask generation out of the O(N*M) loop. Keep a separate cache-friendly table for item masks.
Gives 4-6x speedup.
Fixes #