Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double the wait time between each 429 induced retry #11811

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

dafyddd
Copy link

@dafyddd dafyddd commented Aug 24, 2020

Problem

Summary of Changes

Fixes #

@dafyddd dafyddd changed the title Exponential backoff on waiting between 429 Errors in connection.js fix: double the wait time between each 429 induced retry Aug 24, 2020
@mvines mvines added the CI Pull Request is ready to enter CI label Aug 24, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Aug 24, 2020
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great.

I've contacted Travis CI support about the problem with Travis not starting. They are still incorrectly flagging new users as "abuse" because we are a blockchain and I guess that means they think we are automatically trying to mine BTC on their CI infra 🤦 📉 😿

@mvines
Copy link
Member

mvines commented Aug 25, 2020

Travis support still trying to fix their systems, I'll land manually and watch CI for failure. Thank you @dafyddd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants