Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump max invoke depth to 4 #12742

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Oct 8, 2020

Problem

Limiting invoke depth to 1 is limiting composibility

Summary of Changes

  • Bump it to 4 to handle uses cases partners have brought up
  • Re-arrange compute budget feature handling

Fixes #12724

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #12742 into master will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #12742   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         353      353           
  Lines       84216    84224    +8     
=======================================
+ Hits        68983    68995   +12     
+ Misses      15233    15229    -4     

@jackcmay jackcmay merged commit 2cd7cd3 into solana-labs:master Oct 9, 2020
@jackcmay jackcmay deleted the increase-invoke-depth branch October 9, 2020 17:33
mergify bot pushed a commit that referenced this pull request Oct 9, 2020
(cherry picked from commit 2cd7cd3)

# Conflicts:
#	programs/bpf/rust/invoked/src/processor.rs
#	runtime/src/feature_set.rs
#	runtime/src/message_processor.rs
#	runtime/src/process_instruction.rs
mergify bot pushed a commit that referenced this pull request Oct 9, 2020
(cherry picked from commit 2cd7cd3)
mergify bot added a commit that referenced this pull request Oct 9, 2020
(cherry picked from commit 2cd7cd3)

Co-authored-by: Jack May <jack@solana.com>
mergify bot added a commit that referenced this pull request Oct 9, 2020
* Bump max invoke depth to 4 (#12742)

(cherry picked from commit 2cd7cd3)

# Conflicts:
#	programs/bpf/rust/invoked/src/processor.rs
#	runtime/src/feature_set.rs
#	runtime/src/message_processor.rs
#	runtime/src/process_instruction.rs

* fix conflicts

* resolve conflicts

Co-authored-by: Jack May <jack@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPI call depth is limiting composibility
1 participant