Test for invalid secp256k1 offsets #13026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
secp256k1-test
branch
from
c2f9dba to
da036be
Compare
mvines
approved these changes
Oct 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #13026 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 362 362
Lines 85383 85447 +64
=======================================
+ Hits 70067 70133 +66
+ Misses 15316 15314 -2 |
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
(cherry picked from commit 83c53ae)
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
(cherry picked from commit 83c53ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
off-by-one in signature offset check.
Summary of Changes
Add test and checks for invalid instruction offsets
Fixes #