Track RecycleStore basic stats with needed refactor #15291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Feb 12, 2021
| drop(recycle_stores); | ||
| } else { | ||
| self.stats | ||
| .dropped_stores | ||
| .fetch_add(recycle_stores.len() as u64, Ordering::Relaxed); |
There was a problem hiding this comment.
well, I think this is wrong guessing from the metrics field name.
ryoqun
commented
Feb 12, 2021
| drop(recycle_stores); | ||
| } else { | ||
| self.stats | ||
| .dropped_stores | ||
| .fetch_add(recycle_stores.len() as u64, Ordering::Relaxed); |
There was a problem hiding this comment.
like this(https://github.com/solana-labs/solana/pull/15291/files#r575304322), this was wrong, right?
running mainnet-beta a bit, it looks like I need some ttl-based eviction here too like #15139 |
Codecov Report
@@ Coverage Diff @@
## master #15291 +/- ##
=======================================
Coverage 79.5% 79.5%
=======================================
Files 403 403
Lines 102707 102738 +31
=======================================
+ Hits 81739 81777 +38
+ Misses 20968 20961 -7 |
|
@sakridge Could you review this at your convenient time? I'll soon create another actual eviction pr on top of this. :) |
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2021
* Track RecycleStore basic stats with needed refactor * Fix another wrong metrics def (cherry picked from commit 30f1831)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Needs more info to move forward #15188
Summary of Changes
Introduce pretty straightforward metrics to RecycleStores.
Fixes #