generate_index passes batches of items #17290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
speedup_index4
branch
4 times, most recently
from
e8c211b to
1c61cd6
Compare
|
look at total_us lemond colo machine, snapshot-77779424-AP7QKgrw31e5tBhtPqxejbJbYU8rs6LA97L1Qq7gqpdX.tar.zst |
Codecov Report
@@ Coverage Diff @@
## master #17290 +/- ##
=======================================
Coverage 82.6% 82.7%
=======================================
Files 423 423
Lines 118111 118119 +8
=======================================
+ Hits 97663 97685 +22
+ Misses 20448 20434 -14 |
jeffwashington
force-pushed
the
speedup_index4
branch
3 times, most recently
from
b39d1f0 to
b6ff951
Compare
jeffwashington
force-pushed
the
speedup_index4
branch
2 times, most recently
from
ffedefe to
5982d52
Compare
jeffwashington
commented
May 19, 2021
| &mut w_account_maps, | ||
| new_item, | ||
| ); | ||
| if account_info.is_zero_lamport() { |
There was a problem hiding this comment.
I left this where it was in this pr. It doesn't appear to make a big difference in metrics.
jeffwashington
force-pushed
the
speedup_index4
branch
from
5982d52 to
4e2297b
Compare
sakridge
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Validator startup time is commonly experienced. Generating the index is a large part of that time.
Summary of Changes
Pass account info in a batch. Then, calculate all initial map values prior to acquiring write lock.
Fixes #