tests: cleanup test #17305
Merged
tests: cleanup test #17305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17305 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 421 421
Lines 118046 118042 -4
=========================================
- Hits 97652 97644 -8
- Misses 20394 20398 +4 |
AshwinSekar
previously requested changes
May 18, 2021
There was a problem hiding this comment.
https://github.com/solana-labs/solana/blob/master/runtime/src/accounts_index.rs#L2214 looks like we can change this one as well
yep, 1 more, too. These are the lines that are changing in the other pr that this pr facilitates, so they didn't make the transition. |
AshwinSekar
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Use local in test to make code more straightforward. Test is about to change elsewhere and this change is noisy.
Summary of Changes
Fixes #