shink all slots in parallel on startup #17308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shrink_all_slots_us |
jeffwashington
changed the title
Codecov Report
@@ Coverage Diff @@
## master #17308 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 421 421
Lines 118064 118076 +12
=========================================
- Hits 97687 97667 -20
- Misses 20377 20409 +32 |
carllin
reviewed
May 18, 2021
carllin
reviewed
May 18, 2021
runtime/src/accounts_db.rs
Outdated
| } else { | ||
| self.do_shrink_slot_forced_v1(slot); | ||
| pub fn shrink_all_slots(&self, startup: bool) { | ||
| if startup && self.caching_enabled { |
There was a problem hiding this comment.
any particular reason we can't do the parallel shrink when caching is not enabled?
There was a problem hiding this comment.
I don't want to test that code path or be worried about it ;-)
There was a problem hiding this comment.
We are actively maintaining and improving the caching code path. I have more confidence we will get that codepath right and keep it right.
carllin
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
validator startup time is painful - especially as # accounts grows. There will soon be an issue filed for this.
Summary of Changes
From verify_snapshot_bank, shrink slots in parallel.
Fixes #