-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't log shrink metrics on first call #17328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## master #17328 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 421 423 +2
Lines 118048 118054 +6
=========================================
- Hits 97664 97645 -19
- Misses 20384 20409 +25 |
jeffwashington
force-pushed
the
metrics_log
branch
from
May 19, 2021 18:56
8f3beaf
to
50f034a
Compare
@sakridge suggested simpler logic. |
carllin
previously approved these changes
May 19, 2021
carllin
reviewed
May 19, 2021
jeffwashington
force-pushed
the
metrics_log
branch
from
May 19, 2021 21:55
50f034a
to
c58af22
Compare
jeffwashington
added
the
automerge
Merge this Pull Request automatically once CI passes
label
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shrink metrics always log on first call after creation. This causes noise and bifurcated metrics.
Summary of Changes
Wait to log until it has been 1 second.
Fixes #