Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludes caller's crds values from pull responses #17542

Merged
merged 1 commit into from
May 28, 2021

Conversation

behzadnouri
Copy link
Contributor

Problem

If the crds entry belongs to the caller itself, then the caller will
always have the more recent version of it, regardless of it being
filtered out by the bloom filter or not.

The exception is node-instance types which are meant to detect duplicate
running instances, and those are exempted.

Summary of Changes

  • exclude caller's crds values from pull responses.

If the crds entry belongs to the caller itself, then the caller will
always have the more recent version of it, regardless of it being
filtered out by the bloom filter or not.

The exception is node-instance types which are meant to detect duplicate
running instances, and those are exempted.
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #17542 (a50b657) into master (c81c7fe) will increase coverage by 0.0%.
The diff coverage is 83.3%.

@@           Coverage Diff           @@
##           master   #17542   +/-   ##
=======================================
  Coverage    82.6%    82.6%           
=======================================
  Files         427      427           
  Lines      119146   119149    +3     
=======================================
+ Hits        98476    98483    +7     
+ Misses      20670    20666    -4     

@behzadnouri behzadnouri requested review from sakridge and carllin May 27, 2021 18:26
@behzadnouri behzadnouri merged commit 7cf6e66 into solana-labs:master May 28, 2021
@behzadnouri behzadnouri deleted the exclude-origin branch May 28, 2021 13:19
mergify bot pushed a commit that referenced this pull request Jun 4, 2021
If the crds entry belongs to the caller itself, then the caller will
always have the more recent version of it, regardless of it being
filtered out by the bloom filter or not.

The exception is node-instance types which are meant to detect duplicate
running instances, and those are exempted.

(cherry picked from commit 7cf6e66)
mergify bot added a commit that referenced this pull request Jun 4, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
If the crds entry belongs to the caller itself, then the caller will
always have the more recent version of it, regardless of it being
filtered out by the bloom filter or not.

The exception is node-instance types which are meant to detect duplicate
running instances, and those are exempted.

(cherry picked from commit 7cf6e66)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
@brooksprumo brooksprumo mentioned this pull request Aug 23, 2021
behzadnouri added a commit to behzadnouri/solana that referenced this pull request Sep 27, 2021
solana-labs#17542
excludes caller's crds values from pull responses.

Reverting that commit so that when a (staked) node restarts, it can
obtain its crds values before restart from other nodes.
@behzadnouri behzadnouri mentioned this pull request Sep 27, 2021
behzadnouri added a commit that referenced this pull request Sep 27, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#17542
excludes caller's crds values from pull responses.

Reverting that commit so that when a (staked) node restarts, it can
obtain its crds values before restart from other nodes.
mergify bot pushed a commit that referenced this pull request Sep 27, 2021
#17542
excludes caller's crds values from pull responses.

Reverting that commit so that when a (staked) node restarts, it can
obtain its crds values before restart from other nodes.

(cherry picked from commit 43ed727)
behzadnouri added a commit that referenced this pull request Sep 28, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
#17542
excludes caller's crds values from pull responses.

Reverting that commit so that when a (staked) node restarts, it can
obtain its crds values before restart from other nodes.

(cherry picked from commit 43ed727)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
dankelleher pushed a commit to identity-com/solana that referenced this pull request Nov 24, 2021
solana-labs#17542
excludes caller's crds values from pull responses.

Reverting that commit so that when a (staked) node restarts, it can
obtain its crds values before restart from other nodes.
frits-metalogix added a commit to identity-com/solana that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants