Refactor: Merge MessageProcessor into InvokeContext #20165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…process_message().
…process_message().
…sor::verify() into InvokeContext::verify().
Codecov Report
@@ Coverage Diff @@
## master #20165 +/- ##
=======================================
Coverage 82.7% 82.8%
=======================================
Files 487 487
Lines 135326 135315 -11
=======================================
+ Hits 112036 112049 +13
+ Misses 23290 23266 -24 |
Lichtso
deleted the
refactor/merge_message_processor_into_invoke_context
branch
jackcmay
added a commit
to jackcmay/solana
that referenced
this pull request
Sep 28, 2021
…abs#20165)" This reverts commit df6905c.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Sep 28, 2021
…abs#20165)" This reverts commit df6905c.
jackcmay
added a commit
that referenced
this pull request
Sep 28, 2021
Lichtso
restored the
refactor/merge_message_processor_into_invoke_context
branch
Lichtso
deleted the
refactor/merge_message_processor_into_invoke_context
branch
This was referenced Sep 29, 2021
Closed
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
* Inlines MessageProcessor::execute_instruction() in MessageProcessor::process_message(). * Moves MessageProcessor::create_pre_accounts() into ThisInvokeContext::push(). * Hoists ThisInvokeContext::new() out of loop inside MessageProcessor::process_message(). * Moves MessageProcessor::verify_account_references() and MessageProcessor::verify() into InvokeContext::verify().
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…abs#20165)" (solana-labs#20301) This reverts commit df6905c.
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…olana-labs#20165)" (solana-labs#20301)" This reverts commit 207b5a9.
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…abs#20165)" This reverts commit b2aa56b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MessageProcessorhas no real purpose anymore as most of its functionality has been moved toInstructionProcessorandInvokeContext. Currently, it is redirecting dozens of parameters over multiple function calls without doing much. By removing it we can useInvokeContexttransaction wide instead of creating one per instruction. This way theInvokeContextcan become the runtime wrapper around theTransactionContextof ABIv2 (#19191).Summary of Changes
Moves all instance properties and methods (except for
process_message) out ofMessageProcessor.Fixes #