Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Cleanup InstructionProcessor #21404

Merged

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Nov 23, 2021

Problem

program-runtime/src/instruction_processor.rs is a wild mixture of program-runtime structs and methods which were cut out of the runtime in #19438 to resolve dependency conflicts. The file instruction_processor.rs should be split up, now that the InvokeContext was also moved into the program-runtime crate.

Summary of Changes

  • Moves create_message(), native_invoke(), process_cross_program_instruction() and process_instruction() into InvokeContext
  • Moves ExecuteDetailsTimings into its own file.
  • Moves PreAccount into its own file.

Fixes #

@Lichtso Lichtso force-pushed the refactor/cleanup_instruction_processor branch 3 times, most recently from 40bde96 to 31b9d5d Compare November 23, 2021 21:15
@Lichtso Lichtso force-pushed the refactor/cleanup_instruction_processor branch from 31b9d5d to b58b9d7 Compare November 30, 2021 17:36
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #21404 (b58b9d7) into master (e960634) will increase coverage by 11.3%.
The diff coverage is 80.8%.

@@             Coverage Diff             @@
##           master   #21404       +/-   ##
===========================================
+ Coverage    70.2%    81.5%    +11.3%     
===========================================
  Files          35      506      +471     
  Lines        2067   141724   +139657     
  Branches      295        0      -295     
===========================================
+ Hits         1453   115641   +114188     
- Misses        514    26083    +25569     
+ Partials      100        0      -100     

@Lichtso Lichtso merged commit b78f5b6 into solana-labs:master Dec 1, 2021
@Lichtso Lichtso deleted the refactor/cleanup_instruction_processor branch December 1, 2021 07:54
@Lichtso Lichtso mentioned this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant