(Ledger Store Benchmark) Enable FIFO Compaction in the benchmark #22162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here're some example logs showing the effectiveness of the FIFO compaction. I will run more benchmarks comparing its results with other settings: |
Codecov Report
@@ Coverage Diff @@
## master #22162 +/- ##
=========================================
- Coverage 81.3% 81.2% -0.1%
=========================================
Files 567 567
Lines 154287 154287
=========================================
- Hits 125456 125433 -23
- Misses 28831 28854 +23 |
carllin
reviewed
Feb 4, 2022
carllin
reviewed
Feb 4, 2022
carllin
reviewed
Feb 10, 2022
ledger/src/blockstore_db.rs
Outdated
Comment on lines
320
to
354
| match options.shred_storage_type { | ||
| ShredStorageType::RocksLevel => { | ||
| new_cf_descriptor::<ShredData>(&access_type, &oldest_slot) | ||
| } | ||
| ShredStorageType::RocksFifo => { | ||
| if options.shred_data_cf_size > FIFO_WRITE_BUFFER_SIZE { | ||
| new_cf_descriptor_fifo::<ShredData>(&options.shred_data_cf_size) | ||
| } else { | ||
| warn!( | ||
| "shred_data_cf_size is must be greater than {} for RocksFifo.", | ||
| FIFO_WRITE_BUFFER_SIZE | ||
| ); | ||
| warn!("Fall back to ShredStorageType::RocksLevel for cf::ShredData."); | ||
| new_cf_descriptor::<ShredData>(&access_type, &oldest_slot) | ||
| } | ||
| } | ||
| }, | ||
| match options.shred_storage_type { | ||
| ShredStorageType::RocksLevel => { | ||
| new_cf_descriptor::<ShredCode>(&access_type, &oldest_slot) | ||
| } | ||
| ShredStorageType::RocksFifo => { | ||
| if options.shred_code_cf_size > FIFO_WRITE_BUFFER_SIZE { | ||
| new_cf_descriptor_fifo::<ShredCode>(&options.shred_code_cf_size) | ||
| } else { | ||
| warn!( | ||
| "shred_code_cf_size is must be greater than {} for RocksFifo.", | ||
| FIFO_WRITE_BUFFER_SIZE | ||
| ); | ||
| warn!("Fall back to ShredStorageType::RocksLevel for cf::ShredCode."); | ||
| new_cf_descriptor::<ShredCode>(&access_type, &oldest_slot) | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Can we extract this into a common function that takes a generic T to distinguish between ShredCode and ShredData
There was a problem hiding this comment.
The code was on its stacked PR which is already landed.
I've created #23103 for this.
carllin
reviewed
Feb 10, 2022
ledger/src/blockstore_db.rs
Outdated
Comment on lines
1024
to
1033
| pub shred_data_cf_size: u64, | ||
| // The maximum storage size for storing coding shreds in column family | ||
| // [`cf::CodeShred`]. Typically, coding shreds contribute around 20% of the | ||
| // ledger store storage size if the RPC service is enabled, or 40% if RPC | ||
| // service is not enabled. | ||
| // | ||
| // Currently, this setting is only used when shred_storage_type is set to | ||
| // [`ShredStorageType::RocksFifo`]. | ||
| pub shred_code_cf_size: u64, |
There was a problem hiding this comment.
Since these two fields are only necessary when FIFO compaction is enabled, how about a separate struct FifoCompactionOptions, and we have an optional field here: fifo_compaction_options: Option<FifoCompactionOptions>. Then the default is None for leveled compaction, which communicates the dependency between these fields and fifo compaction
There was a problem hiding this comment.
These two are from its parent PR (which is already merged.). I will incorporate the comments in a separate PR.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR enables FIFO Compaction in the test_ledger_cleanup_compaction benchmark.
Note that this PR is based on top of two stack PRs: #22108 and #22140.
To enable FIFO compaction, the following arguments should be set:
FIFO_COMPACTION=true
CLEANUP_SERVICE=false
SHRED_DATA_CF_SIZE=10000000000 // this controls when to delete the oldest SST file.
Example command to use FIFO compaction in the benchmark:
BENCHMARK_SLOTS=10000000 NUM_WRITERS=9 BATCH_SIZE=1 SHREDS_PER_SLOT=25 PRE_GENERATE_DATA=false CLEANUP_BLOCKSTORE=false CLEANUP_SERVICE=false FIFO_COMPACTION=true SHRED_DATA_CF_SIZE=10000000000 cargo test --release tests::test_ledger_cleanup_compaction -- --exact --nocapture
Observed the FIFO compaction working properly by checking the output and the RocksDB LOG file.