Move cap_accounts_data_len feature gate only around new error #23048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23048 +/- ##
=========================================
- Coverage 81.2% 81.2% -0.1%
=========================================
Files 564 564
Lines 153419 153422 +3
=========================================
- Hits 124667 124655 -12
- Misses 28752 28767 +15 |
| if self | ||
| .feature_set | ||
| .is_active(&feature_set::cap_accounts_data_len::id()) | ||
| && total_collected.account_data_len_reclaimed > 0 | ||
| { |
There was a problem hiding this comment.
I just made this change yesterday, now to undo it... #22918
There was a problem hiding this comment.
If I understand correctly you are not checking the feature gate here because update_accounts_data_len() won't throw an error / change the outcome and you want the calculation to happen for statistical purposes, right?
There was a problem hiding this comment.
Correct!
Yesterday when I added the feature gate here, it was to keep everything consistent w.r.t. accounts_data_len; either nothing changes it, or both rent and transaction processing changes it. So similarly now, to track the changes with consistency for stats, I need to remove the feature gate both here (rent) and transaction processing.
(cherry picked from commit 0a1ab94)
Problem
We'd like to track accounts data size independent of the
cap_accounts_data_lenfeature. The accounts data size is already a datapoint inbank_forks::SetRootMetrics, but it currently never updates since the feature is disabled.Summary of Changes
InvokeContextalways consumes from AccountsDataMeter. If feature is disabled, do not throw any errors.